deepthi912 commented on code in PR #13789:
URL: https://github.com/apache/pinot/pull/13789#discussion_r1733939096


##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##########
@@ -44,6 +49,7 @@
  * the column indexes available.
  */
 public class TableMetadataReader {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(TableMetadataReader.class);

Review Comment:
   Removed it



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java:
##########
@@ -173,6 +174,12 @@ private File getValidDocIdsSnapshotFile() {
         V1Constants.VALID_DOC_IDS_SNAPSHOT_FILE_NAME);
   }
 
+  public boolean isReloadNeeded(IndexLoadingConfig indexLoadingConfig)
+      throws Exception {
+    //if re processing or reload is needed on a segment then return true

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to