Jackie-Jiang commented on PR #13673: URL: https://github.com/apache/pinot/pull/13673#issuecomment-2315905635
> Question: This PR modifies the way functions are resolved, but do not change semantics because right now we don't have overload functions right? ie we have a single `sum` function for doubles. > > Once we add overload functions into our registry (ie `sum` for int, `sum` for longs, etc) queries that previously returned a double may return different types. Am I right? This PR only affects scalar functions. Aggregates are handled differently. Currently in multi-stage engine, results are converted into the correct type (e.g. result type of SUM(longCol) is converted from double to long before sending to the next stage). See the tests to see the behavior change on comparisons for different data types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
