Jackie-Jiang commented on code in PR #13905:
URL: https://github.com/apache/pinot/pull/13905#discussion_r1735183987
##########
pinot-core/src/test/java/org/apache/pinot/core/util/CrcUtilsTest.java:
##########
@@ -38,8 +38,8 @@
public class CrcUtilsTest {
private static final File INDEX_DIR = new File(FileUtils.getTempDirectory(),
"CrcUtilsTest");
private static final String AVRO_DATA = "data/test_data-mv.avro";
- private static final long EXPECTED_V1_CRC = 2708456273L;
- private static final long EXPECTED_V3_CRC = 2796149869L;
+ private static final long EXPECTED_V1_CRC = 3087108662L;
Review Comment:
Ideally we want to keep it the same, or we might end up downloading segments
because different versions of Pinot generating different crc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
