gortiz commented on code in PR #13303:
URL: https://github.com/apache/pinot/pull/13303#discussion_r1738737077
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java:
##########
@@ -265,10 +186,15 @@ public double getDouble(int rowId, int colId) {
@Override
public BigDecimal getBigDecimal(int rowId, int colId) {
- int size = positionOffsetInVariableBufferAndGetLength(rowId, colId);
- ByteBuffer byteBuffer = _variableSizeData.slice();
- byteBuffer.limit(size);
- return BigDecimalUtils.deserialize(byteBuffer);
+ // TODO: Add a allocation free deserialization mechanism.
+ int offsetInFixed = getOffsetInFixedBuffer(rowId, colId);
+ int size = _fixedSizeData.getInt(offsetInFixed + 4);
+ int offsetInVar = _fixedSizeData.getInt(offsetInFixed);
+
+ byte[] buffer = new byte[size];
+ _variableSizeData.copyTo(offsetInVar, buffer, 0, size);
Review Comment:
Exactly ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
