cbalci commented on code in PR #13748:
URL: https://github.com/apache/pinot/pull/13748#discussion_r1745988697
##########
.github/workflows/pinot_tests.yml:
##########
@@ -123,6 +123,11 @@ jobs:
--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED
--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
+ --add-opens=java.base/java.nio=ALL-UNNAMED
+ --add-opens=java.base/sun.nio.ch=ALL-UNNAMED
+ --add-opens=java.base/java.lang=ALL-UNNAMED
+ --add-opens=java.base/java.util=ALL-UNNAMED
+ --add-opens=java.base/java.lang.reflect=ALL-UNNAMED
Review Comment:
@ankitsultana I was able to fix the unit test failures on JDK21 by adding VM
options.
Sorry for the commit spam, for some reason Github CI behavior is different
than my local setup so it took a while to get to the correct config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]