gortiz commented on code in PR #13733:
URL: https://github.com/apache/pinot/pull/13733#discussion_r1754564993
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/TransformOperator.java:
##########
@@ -86,7 +88,17 @@ public String toExplainString() {
}
protected String getExplainName() {
- return EXPLAIN_NAME;
+ return CaseFormat.UPPER_UNDERSCORE.to(CaseFormat.UPPER_CAMEL,
EXPLAIN_NAME);
Review Comment:
Yes. Good call. Luckily a test detected the same problem. The code is
changed now and `toExplainString` (the one used in V1) does not call
`getExplainName` (the one used in V2). Names are very confusing btw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
