rfscholte commented on code in PR #13854:
URL: https://github.com/apache/pinot/pull/13854#discussion_r1755074144
##########
pom.xml:
##########
@@ -354,6 +354,55 @@
<argLine>-Xms4g -Xmx4g -Dlog4j2.configurationFile=log4j2.xml</argLine>
</properties>
</profile>
+ <profile>
+ <id>codecoverage</id>
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <!-- used when runnning jacoco:report-aggregate@report via
commandline -->
+ <id>report</id>
+ <configuration>
+ <skip>true</skip> <!-- default for all modules, overwrite
for root project -->
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>prepare-agent</id>
+ <goals>
+ <goal>prepare-agent</goal>
+ </goals>
+ <configuration>
+ <append>true</append>
+ <includes>
+ <include>org/apache/pinot/**/*</include>
+ </includes>
+ </configuration>
+ </execution>
+ <execution>
+ <id>report</id>
+ <inherited>false</inherited>
+ <configuration>
+ <skip>false</skip>
Review Comment:
let me verify if this is still required. If it was part of the buildcycle,
you only want to execute this goal on the root, not on all the others. Here the
default behavior of skipping is in plugin management, but with the
execution+inherited=false you can configure plugins to do things that are not
inherited by their children.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
