rajagopr commented on code in PR #13646:
URL: https://github.com/apache/pinot/pull/13646#discussion_r1755592659
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java:
##########
@@ -276,6 +336,144 @@ private void processExistingSegment(String
tableNameWithType, SegmentMetadata se
}
}
+ // process a batch of existing segments
Review Comment:
Originally, I had modified the existing methods to deal with a list of
segments as opposed to a single segment. Later decided to use separate methods
for single segment upload vs batch upload as recommended by Jackie. His
original comment as below.
```
Consider using different method to handle single segment upload vs batch
segment upload. We may extract common part as needed, but modifying the
existing flow can be risky. It can cause backward incompatible if any error
handling behavior is changed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
