klsince commented on code in PR #13992:
URL: https://github.com/apache/pinot/pull/13992#discussion_r1761893831
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -153,11 +164,17 @@ protected BasePartitionUpsertMetadataManager(String
tableNameWithType, int parti
_metadataTTL = context.getMetadataTTL();
_deletedKeysTTL = context.getDeletedKeysTTL();
_tableIndexDir = context.getTableIndexDir();
+ long trackingTimeMs = context.getNewSegmentTrackingTimeMs();
UpsertConfig.ConsistencyMode cmode = context.getConsistencyMode();
if (cmode == UpsertConfig.ConsistencyMode.SYNC || cmode ==
UpsertConfig.ConsistencyMode.SNAPSHOT) {
_upsertViewManager = new UpsertViewManager(cmode, context);
+ // For consistency mode, we have to track newly added segments, so use
default tracking time to enable the
+ // tracking of newly added segments if it's not enabled explicitly.
+ _newSegmentTrackingTimeMs =
+ trackingTimeMs > 0 ? trackingTimeMs :
UpsertViewManager.DEFAULT_NEW_SEGMENT_TRACKING_TIME_MS;
Review Comment:
sgtm, added validation when create tables, but I'll keep this fallback
handling for current users of consistency mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
