rfscholte commented on code in PR #14003:
URL: https://github.com/apache/pinot/pull/14003#discussion_r1764886589
##########
pinot-broker/src/test/resources/log4j2.xml:
##########
@@ -26,11 +26,12 @@
</Console>
</Appenders>
<Loggers>
- <Logger name="org.apache.pinot" level="warn" additivity="false">
+ <Root level="OFF"/>
Review Comment:
I assume this is only an issue for integration tests, where you need to have
a pinot component is a specific state before running the tests. In such case
the exception of the test is not enough; in such case the pinot component
logging could help.
It is possible to use system properties in log4j.xml files:
https://logging.apache.org/log4j/2.x/manual/lookups.html
For me the main question is: should the logging be available when the tests
fails, or is it good enough to rerun the test with adjusted settings/arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
