mcvsubbu commented on code in PR #14024:
URL: https://github.com/apache/pinot/pull/14024#discussion_r1765411682
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##########
@@ -113,27 +110,18 @@ protected void processTable(String tableNameWithType,
Context context) {
runSegmentLevelValidation(tableConfig, streamConfig);
}
- if (shouldEnsureConsuming(tableNameWithType, context)) {
- _llcRealtimeSegmentManager.ensureAllPartitionsConsuming(tableConfig,
streamConfig,
- context._recreateDeletedConsumingSegment, context._offsetCriteria);
+ if (shouldEnsureConsuming(tableNameWithType)) {
+ _llcRealtimeSegmentManager.ensureAllPartitionsConsuming(tableConfig,
streamConfig, context._offsetCriteria);
}
}
- private boolean shouldEnsureConsuming(String tableNameWithType, Context
context) {
- // Keeps the table paused/unpaused based pause validations.
- // Skips updating the pause state if table is paused by admin
+ private boolean shouldEnsureConsuming(String tableNameWithType) {
Review Comment:
nit: can we inline computePauseState() method here? (since there is only one
user for the method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
