anandheritage commented on code in PR #14050:
URL: https://github.com/apache/pinot/pull/14050#discussion_r1769561740
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java:
##########
@@ -107,7 +107,7 @@ public BlockDocIdIterator iterator() {
// evaluate the bitmaps in the order of the lowest matching num docIds
comes first, so that we minimize the number
// of containers (range) for comparison from the beginning, as will
minimize the effort of bitmap AND application
- bitmapBasedDocIdIterators.sort(Comparator.comparing(x ->
x.getDocIds().getCardinality()));
+ bitmapBasedDocIdIterators.sort(Comparator.comparing(x ->
x.getDocIds().getContainerCount()));
Review Comment:
Will make that change - Looking for a way to becnhmark this change. Can you
recommend something ? Do we have a common tool to do that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
