gortiz commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1772935221
########## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/plan/serde/TimeSeriesPlanSerde.java: ########## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.tsdb.spi.plan.serde; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.DeserializationFeature; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.node.ArrayNode; +import com.fasterxml.jackson.databind.node.ObjectNode; +import org.apache.pinot.spi.annotations.InterfaceStability; +import org.apache.pinot.tsdb.spi.plan.BaseTimeSeriesPlanNode; +import org.apache.pinot.tsdb.spi.plan.ScanFilterAndProjectPlanNode; + + +/** + * We have implemented a custom serialization/deserialization mechanism for time series plans. This allows users to + * use Jackson to annotate their plan nodes as shown in {@link ScanFilterAndProjectPlanNode}, which is used for + * plan serde for broker/server communication. + * TODO: There are limitations to this and we will change this soon. Issues: + * 1. Pinot TS SPI is compiled in Pinot distribution and Jackson deps get shaded usually. + * 2. The plugins have to shade the dependency in the exact same way, which is obviously error-prone and not ideal. + */ +@InterfaceStability.Evolving +public class TimeSeriesPlanSerde { Review Comment: This is the 3rd time we define how to serialize and deserialize plans and we still have issues in multi-stage query engine (ie I had to write a lot of code to be able to implement physical explain in multi-stage query engine, see https://github.com/apache/pinot/pull/13733). I think we should honestly think about moving to something more general we can always use, like [substrait](https://substrait.io/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
