yashmayya commented on code in PR #14089: URL: https://github.com/apache/pinot/pull/14089#discussion_r1777085061
########## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/arithmetic/PolymorphicBinaryArithmeticScalarFunction.java: ########## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.function.scalar.arithmetic; + +import javax.annotation.Nullable; +import org.apache.pinot.common.function.FunctionInfo; +import org.apache.pinot.common.function.PinotScalarFunction; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; + + +/** + * Base class for polymorphic binary arithmetic scalar functions + */ +public abstract class PolymorphicBinaryArithmeticScalarFunction implements PinotScalarFunction { + + @Nullable + @Override + public FunctionInfo getFunctionInfo(ColumnDataType[] argumentTypes) { + if (argumentTypes.length != 2) { + return null; + } + + return functionInfoForTypes(argumentTypes[0].getStoredType(), argumentTypes[1].getStoredType()); + } + + @Nullable + @Override + public FunctionInfo getFunctionInfo(int numArguments) { + if (numArguments != 2) { + return null; + } + + // For backward compatibility + return functionInfoForType(ColumnDataType.DOUBLE); + } + + private FunctionInfo functionInfoForTypes(ColumnDataType argumentType1, ColumnDataType argumentType2) { + if (argumentType1 == ColumnDataType.DOUBLE || argumentType2 == ColumnDataType.DOUBLE + || argumentType1 == ColumnDataType.FLOAT || argumentType2 == ColumnDataType.FLOAT) { + return functionInfoForType(ColumnDataType.DOUBLE); + } Review Comment: This check isn't strictly necessary since we're falling back to double based comparison anyway but I started writing it this way since we could potentially add more types and type combinations here in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
