tibrewalpratik17 commented on code in PR #14064:
URL: https://github.com/apache/pinot/pull/14064#discussion_r1777746952
##########
pinot-common/src/test/java/org/apache/pinot/common/metrics/AbstractMetricsTest.java:
##########
@@ -268,4 +274,207 @@ public void testMeteredMetrics() {
testMetrics.getMetricsRegistry().allMetrics().keySet().forEach(testMetrics.getMetricsRegistry()::removeMetric);
Assert.assertTrue(testMetrics.getMetricsRegistry().allMetrics().isEmpty());
}
+
+ @Test
+ public void testGlobalGaugeMetricsAsyncAddRemove() throws
ExecutionException, InterruptedException {
+ ControllerMetrics controllerMetrics = buildTestMetrics();
+ int gaugeOperationsRuntimeMs = 100;
+
+ ExecutorService executorService = Executors.newFixedThreadPool(2);
+ long endTime = System.currentTimeMillis() + gaugeOperationsRuntimeMs;
+
+ Future<?> addFuture = executorService.submit(() -> {
+ while (System.currentTimeMillis() < endTime + gaugeOperationsRuntimeMs) {
Review Comment:
> there can be delays in thread scheduling, which can lead to the
removeGauge to be run last
endTime is decided before spawning both threads so i guess even if the other
thread is scheduled later, `System.currentTimeMillis < endTime` would return
false and not remove gauge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
