Jackie-Jiang commented on code in PR #14098:
URL: https://github.com/apache/pinot/pull/14098#discussion_r1779276632
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -870,12 +875,6 @@ public Schema getSchema() {
return _schema;
}
- @VisibleForTesting
- public void setTableConfig(TableConfig tableConfig) {
Review Comment:
The main problem is that the setters are not reflected back to table config,
which is causing inconsistency across configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
