This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 93fbf98be3 Cleanup system output (#14152)
93fbf98be3 is described below

commit 93fbf98be3e4db7b39553708b37037d92f0325cc
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Wed Oct 2 16:36:28 2024 -0700

    Cleanup system output (#14152)
---
 .../pinot/broker/queryquota/HitCounterTest.java      |  4 ----
 .../apache/pinot/client/ConnectionFactoryTest.java   | 18 ------------------
 .../org/apache/pinot/common/utils/BcryptUtils.java   |  7 ++-----
 .../apache/pinot/common/utils/FALFInternerTest.java  |  4 ----
 .../pinot/connector/flink/FlinkQuickStart.java       |  5 +----
 .../segment/StrictRealtimeSegmentAssignmentTest.java |  1 -
 .../optimizer/filter/NumericalFilterOptimizer.java   | 20 ++++++++++----------
 .../accounting/ResourceManagerAccountingTest.java    |  4 ++--
 .../JsonUnnestIngestionFromAvroQueriesTest.java      |  1 -
 .../pinot/integration/tests/custom/ArrayTest.java    |  2 --
 .../tests/custom/MapFieldTypeRealtimeTest.java       | 10 ----------
 .../integration/tests/custom/MapFieldTypeTest.java   | 10 ----------
 .../integration/tests/custom/WindowFunnelTest.java   |  3 ---
 .../pinot/plugin/filesystem/S3PinotFSTest.java       |  1 -
 .../protobuf/ProtoBufCodeGenMessageDecoder.java      |  1 -
 .../ComplexTypeTransformerTest.java                  |  1 -
 16 files changed, 15 insertions(+), 77 deletions(-)

diff --git 
a/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HitCounterTest.java
 
b/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HitCounterTest.java
index 635838b83e..d69cc56e01 100644
--- 
a/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HitCounterTest.java
+++ 
b/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/HitCounterTest.java
@@ -84,7 +84,6 @@ public class HitCounterTest {
     Random random = new Random();
     // Run the test 3 times
     for (int k = 0; k < 3; k++) {
-      long startTime = System.currentTimeMillis();
       int numThreads = 30;
       int numHitsPerThread = 200000;
       int expectedHitCount = numThreads * numHitsPerThread;
@@ -109,9 +108,6 @@ public class HitCounterTest {
 
       Assert.assertNotNull(hitCounter);
       Assert.assertEquals(hitCounter.getHitCount(), expectedHitCount);
-
-      long duration = System.currentTimeMillis() - startTime;
-      System.out.println(duration);
     }
   }
 }
diff --git 
a/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ConnectionFactoryTest.java
 
b/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ConnectionFactoryTest.java
index e12dc873f6..18c51b17f1 100644
--- 
a/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ConnectionFactoryTest.java
+++ 
b/pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ConnectionFactoryTest.java
@@ -120,22 +120,4 @@ public class ConnectionFactoryTest {
     Assert.assertNotNull(connection.getTransport());
     Assert.assertNotNull(connection.getTransport().getClientMetrics());
   }
-
-  // For testing DynamicBrokerSelector
-
-  /**
-   * ConnectionFactoryTest <ZK_URL> <tableName> <query>
-   * @param args
-   */
-  public static void main(String[] args) {
-    if (args.length != 3) {
-      System.err.println("USAGE ConnectionFactoryTest <ZK_URL> <tableName> 
<query>");
-      System.exit(1);
-    }
-    String zkUrl = args[0];
-    Connection connection = ConnectionFactory.fromZookeeper(zkUrl);
-    String tableName = args[1];
-    ResultSetGroup resultSetGroup = connection.execute(tableName, args[2]);
-    System.out.println(resultSetGroup);
-  }
 }
diff --git 
a/pinot-common/src/main/java/org/apache/pinot/common/utils/BcryptUtils.java 
b/pinot-common/src/main/java/org/apache/pinot/common/utils/BcryptUtils.java
index 7857552e97..718f9008d2 100644
--- a/pinot-common/src/main/java/org/apache/pinot/common/utils/BcryptUtils.java
+++ b/pinot-common/src/main/java/org/apache/pinot/common/utils/BcryptUtils.java
@@ -40,13 +40,10 @@ public class BcryptUtils {
   }
 
   public static boolean checkpw(String password, String encryptedPassword) {
-    boolean isMatch = false;
     try {
-      isMatch = BCrypt.checkpw(password, encryptedPassword);
+      return BCrypt.checkpw(password, encryptedPassword);
     } catch (Exception e) {
-      System.out.println(e.getMessage());
-    } finally {
-      return isMatch;
+      return false;
     }
   }
 
diff --git 
a/pinot-common/src/test/java/org/apache/pinot/common/utils/FALFInternerTest.java
 
b/pinot-common/src/test/java/org/apache/pinot/common/utils/FALFInternerTest.java
index ad49bf768f..180d1c84b2 100644
--- 
a/pinot-common/src/test/java/org/apache/pinot/common/utils/FALFInternerTest.java
+++ 
b/pinot-common/src/test/java/org/apache/pinot/common/utils/FALFInternerTest.java
@@ -53,10 +53,6 @@ public class FALFInternerTest {
     int nHits2 = runInterning(allObjs, falfInterner, true);
     int nHits3 = runInterning(allObjs, falfInternerCustomHash, true);
 
-    System.out.println(nHits1);
-    System.out.println(nHits2);
-    System.out.println(nHits3);
-
     // For the exact interner, we should get a hit for each object except the
     // first nUniqueObjs.
     Assert.assertEquals(nHits1, nTotalObjs - nUniqueObjs);
diff --git 
a/pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/FlinkQuickStart.java
 
b/pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/FlinkQuickStart.java
index c27fc335bb..0cfff2f51d 100644
--- 
a/pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/FlinkQuickStart.java
+++ 
b/pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/FlinkQuickStart.java
@@ -58,13 +58,10 @@ public final class FlinkQuickStart {
     ClassLoader classLoader = FlinkQuickStart.class.getClassLoader();
     final URL resource = classLoader.getResource("starbucks-stores-world.csv");
     try (BufferedReader br = new BufferedReader(new 
InputStreamReader(resource.openStream()))) {
-      String line = null;
+      String line;
       while ((line = br.readLine()) != null) {
         // split by comma, but in quotes
         String[] parts = line.split(",(?=(?:[^\"]*\"[^\"]*\")*[^\"]*$)", -1);
-        if (parts[0].isEmpty() || parts[1].isEmpty()) {
-          System.out.println(line);
-        }
         rows.add(Row.of(Float.parseFloat(parts[0]), 
Float.parseFloat(parts[1]), parts[2], parts[3]));
       }
     }
diff --git 
a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignmentTest.java
 
b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignmentTest.java
index 13520bb4f8..6775329d37 100644
--- 
a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignmentTest.java
+++ 
b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/segment/StrictRealtimeSegmentAssignmentTest.java
@@ -253,7 +253,6 @@ public class StrictRealtimeSegmentAssignmentTest {
       }
       addToAssignment(currentAssignment, segmentId, instancesAssigned);
     }
-    System.out.println(currentAssignment);
   }
 
   @Test(expectedExceptions = IllegalStateException.class)
diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java
index b0bcf42471..7d2336a1a0 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java
@@ -160,11 +160,11 @@ public class NumericalFilterOptimizer extends 
BaseAndOrBooleanFilterOptimizer {
         }
         break;
       }
-      case FLOAT_VALUE: {
-        float actual = Float.intBitsToFloat(rhs.getLiteral().getFloatValue());
-        System.out.println(actual);
-        break;
-      }
+      // TODO: Add support for FLOAT_VALUE
+//      case FLOAT_VALUE: {
+//        float actual = 
Float.intBitsToFloat(rhs.getLiteral().getFloatValue());
+//        break;
+//      }
       case DOUBLE_VALUE: {
         double actual = rhs.getLiteral().getDoubleValue();
         switch (dataType) {
@@ -271,11 +271,11 @@ public class NumericalFilterOptimizer extends 
BaseAndOrBooleanFilterOptimizer {
         }
         break;
       }
-      case FLOAT_VALUE: {
-        float actual = Float.intBitsToFloat(rhs.getLiteral().getFloatValue());
-        System.out.println(actual);
-        break;
-      }
+      // TODO: Add support for FLOAT_VALUE
+//      case FLOAT_VALUE: {
+//        float actual = 
Float.intBitsToFloat(rhs.getLiteral().getFloatValue());
+//        break;
+//      }
       case DOUBLE_VALUE: {
         double actual = rhs.getLiteral().getDoubleValue();
         switch (dataType) {
diff --git 
a/pinot-core/src/test/java/org/apache/pinot/core/accounting/ResourceManagerAccountingTest.java
 
b/pinot-core/src/test/java/org/apache/pinot/core/accounting/ResourceManagerAccountingTest.java
index f8c0e4562d..852e847d5a 100644
--- 
a/pinot-core/src/test/java/org/apache/pinot/core/accounting/ResourceManagerAccountingTest.java
+++ 
b/pinot-core/src/test/java/org/apache/pinot/core/accounting/ResourceManagerAccountingTest.java
@@ -185,7 +185,7 @@ public class ResourceManagerAccountingTest {
               }
             }
             Tracing.ThreadAccountantOps.clear();
-            System.out.println(a[0][0]);
+            Assert.assertEquals(a[0][0], 0);
             countDownLatch.countDown();
           });
         }
@@ -529,7 +529,7 @@ public class ResourceManagerAccountingTest {
               }
             }
             Tracing.ThreadAccountantOps.clear();
-            System.out.println(a[0][0]);
+            Assert.assertEquals(a[0][0], 0);
             countDownLatch.countDown();
           });
         }
diff --git 
a/pinot-core/src/test/java/org/apache/pinot/queries/JsonUnnestIngestionFromAvroQueriesTest.java
 
b/pinot-core/src/test/java/org/apache/pinot/queries/JsonUnnestIngestionFromAvroQueriesTest.java
index 9694445dd7..2d6b26883d 100644
--- 
a/pinot-core/src/test/java/org/apache/pinot/queries/JsonUnnestIngestionFromAvroQueriesTest.java
+++ 
b/pinot-core/src/test/java/org/apache/pinot/queries/JsonUnnestIngestionFromAvroQueriesTest.java
@@ -378,7 +378,6 @@ public class JsonUnnestIngestionFromAvroQueriesTest extends 
BaseQueriesTest {
     Assert.assertEquals(rows.size(), 14);
     int index = 0;
     for (Object[] row : rows) {
-      System.out.println(Arrays.toString(row));
       Assert.assertEquals(Arrays.toString(row), expecteds.get(index++));
     }
   }
diff --git 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java
 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java
index 921dc6e45e..78fda6266e 100644
--- 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java
+++ 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/ArrayTest.java
@@ -788,7 +788,6 @@ public class ArrayTest extends 
CustomDataQueryClusterIntegrationTest {
         String.format("SELECT %s, %s, %s, %s FROM %s LIMIT %d", INT_COLUMN, 
BOOLEAN_COLUMN, BOOLEAN_FROM_INT_COLUMN,
             BOOLEAN_FROM_STRING_COLUMN, getTableName(), getCountStarResult());
     JsonNode result = postQuery(query).get("resultTable");
-    System.out.println("result = " + result);
     JsonNode columnDataTypesNode = 
result.get("dataSchema").get("columnDataTypes");
     assertEquals(columnDataTypesNode.get(0).textValue(), "INT");
     assertEquals(columnDataTypesNode.get(1).textValue(), "BOOLEAN");
@@ -813,7 +812,6 @@ public class ArrayTest extends 
CustomDataQueryClusterIntegrationTest {
         String.format("SELECT %s, %s, %s FROM %s LIMIT %d", 
BOOLEAN_ARRAY_COLUMN, BOOLEAN_FROM_INT_ARRAY_COLUMN,
             BOOLEAN_FROM_STRING_ARRAY_COLUMN, getTableName(), 
getCountStarResult());
     JsonNode result = postQuery(query).get("resultTable");
-    System.out.println("result = " + result);
     JsonNode columnDataTypesNode = 
result.get("dataSchema").get("columnDataTypes");
     assertEquals(columnDataTypesNode.get(0).textValue(), "BOOLEAN_ARRAY");
     assertEquals(columnDataTypesNode.get(1).textValue(), "BOOLEAN_ARRAY");
diff --git 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeRealtimeTest.java
 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeRealtimeTest.java
index 5a2c0a7708..a9cee052b1 100644
--- 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeRealtimeTest.java
+++ 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeRealtimeTest.java
@@ -140,7 +140,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     // Selection only
     String query = "SELECT * FROM " + getTableName() + " ORDER BY ts";
     JsonNode pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     JsonNode rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
@@ -157,7 +156,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     // Selection only
     query = "SELECT stringMap['k0'], intMap['k0'] FROM " + getTableName() + " 
ORDER BY ts";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
@@ -176,7 +174,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
-    System.out.println("pinotResponse = " + pinotResponse);
 
     assertEquals(rows.get(0).get(0).intValue(), -2147483648);
     assertEquals(rows.get(0).get(1).intValue(), -2147483648);
@@ -196,7 +193,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     // Aggregation only
     query = "SELECT MAX(intMap['k0']), MAX(intMap['k1']) FROM " + 
getTableName();
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     
assertEquals(pinotResponse.get("resultTable").get("rows").get(0).get(0).intValue(),
 NUM_DOCS - 1);
     
assertEquals(pinotResponse.get("resultTable").get("rows").get(0).get(1).intValue(),
 NUM_DOCS - 1);
@@ -205,7 +201,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     query = "SELECT stringMap['k0'] AS key, MIN(intMap['k0']) AS value FROM " 
+ getTableName()
         + " GROUP BY key ORDER BY value";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
@@ -219,7 +214,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     // Filter
     query = "SELECT stringMap['k2'] FROM " + getTableName() + " WHERE 
stringMap['k1']  = '25'";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 1);
@@ -227,7 +221,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
 
     query = "SELECT intMap['k2'] FROM " + getTableName() + " WHERE 
intMap['k1']  = 25";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 1);
@@ -236,13 +229,11 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     // Filter on non-existing key
     query = "SELECT stringMap['k2'] FROM " + getTableName() + " WHERE 
stringMap['kk']  = '25'";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 0);
     query = "SELECT intMap['k2'] FROM " + getTableName() + " WHERE 
intMap['kk']  = 25";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 0);
@@ -250,7 +241,6 @@ public class MapFieldTypeRealtimeTest extends 
CustomDataQueryClusterIntegrationT
     // Select non-existing key
     query = "SELECT stringMap['kkk'], intMap['kkk'] FROM " + getTableName();
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     for (int i = 0; i < getSelectionDefaultDocCount(); i++) {
diff --git 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeTest.java
 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeTest.java
index d63495a5f3..74ce24e3d7 100644
--- 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeTest.java
+++ 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeTest.java
@@ -133,7 +133,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     // Selection only
     String query = "SELECT * FROM " + getTableName();
     JsonNode pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     JsonNode rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
@@ -150,7 +149,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     // Selection only
     query = "SELECT stringMap['k0'], intMap['k0'] FROM " + getTableName();
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
@@ -169,7 +167,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
-    System.out.println("pinotResponse = " + pinotResponse);
 
     assertEquals(rows.get(0).get(0).intValue(), -2147483648);
     assertEquals(rows.get(0).get(1).intValue(), -2147483648);
@@ -189,7 +186,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     // Aggregation only
     query = "SELECT MAX(intMap['k0']), MAX(intMap['k1']) FROM " + 
getTableName();
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     
assertEquals(pinotResponse.get("resultTable").get("rows").get(0).get(0).intValue(),
 NUM_DOCS - 1);
     
assertEquals(pinotResponse.get("resultTable").get("rows").get(0).get(1).intValue(),
 NUM_DOCS - 1);
@@ -198,7 +194,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     query = "SELECT stringMap['k0'] AS key, MIN(intMap['k0']) AS value FROM " 
+ getTableName()
         + " GROUP BY key ORDER BY value";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), getSelectionDefaultDocCount());
@@ -212,7 +207,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     // Filter
     query = "SELECT stringMap['k2'] FROM " + getTableName() + " WHERE 
stringMap['k1']  = '25'";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 1);
@@ -220,7 +214,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
 
     query = "SELECT intMap['k2'] FROM " + getTableName() + " WHERE 
intMap['k1']  = 25";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 1);
@@ -229,13 +222,11 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     // Filter on non-existing key
     query = "SELECT stringMap['k2'] FROM " + getTableName() + " WHERE 
stringMap['kk']  = '25'";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 0);
     query = "SELECT intMap['k2'] FROM " + getTableName() + " WHERE 
intMap['kk']  = 25";
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     assertEquals(rows.size(), 0);
@@ -243,7 +234,6 @@ public class MapFieldTypeTest extends 
CustomDataQueryClusterIntegrationTest {
     // Select non-existing key
     query = "SELECT stringMap['kkk'], intMap['kkk'] FROM " + getTableName();
     pinotResponse = postQuery(query);
-    System.out.println("pinotResponse = " + pinotResponse);
     assertEquals(pinotResponse.get("exceptions").size(), 0);
     rows = pinotResponse.get("resultTable").get("rows");
     for (int i = 0; i < getSelectionDefaultDocCount(); i++) {
diff --git 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/WindowFunnelTest.java
 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/WindowFunnelTest.java
index e41f235116..2ffcc73a59 100644
--- 
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/WindowFunnelTest.java
+++ 
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/WindowFunnelTest.java
@@ -537,7 +537,6 @@ public class WindowFunnelTest extends 
CustomDataQueryClusterIntegrationTest {
             + "FROM %s GROUP BY userId ORDER BY userId LIMIT %d) "
             + "SELECT sumArrayLong(steps) FROM t1", getTableName(), 
getCountStarResult());
     JsonNode jsonNode = postQuery(query);
-    System.out.println("jsonNode = " + jsonNode);
     JsonNode rows = jsonNode.get("resultTable").get("rows");
     assertEquals(rows.size(), 1);
     JsonNode row = rows.get(0);
@@ -558,7 +557,6 @@ public class WindowFunnelTest extends 
CustomDataQueryClusterIntegrationTest {
             + "FROM %s GROUP BY userId ORDER BY userId LIMIT %d) "
             + "SELECT sumArrayLong(steps) FROM t1", getTableName(), 
getCountStarResult());
     jsonNode = postQuery(query);
-    System.out.println("jsonNode = " + jsonNode);
     rows = jsonNode.get("resultTable").get("rows");
     assertEquals(rows.size(), 1);
     row = rows.get(0);
@@ -579,7 +577,6 @@ public class WindowFunnelTest extends 
CustomDataQueryClusterIntegrationTest {
             + "FROM %s GROUP BY userId ORDER BY userId LIMIT %d) "
             + "SELECT sumArrayLong(steps) FROM t1", getTableName(), 
getCountStarResult());
     jsonNode = postQuery(query);
-    System.out.println("jsonNode = " + jsonNode);
     rows = jsonNode.get("resultTable").get("rows");
     assertEquals(rows.size(), 1);
     row = rows.get(0);
diff --git 
a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
 
b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
index 18ca80f004..00ff8d03f9 100644
--- 
a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
+++ 
b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
@@ -389,7 +389,6 @@ public class S3PinotFSTest {
     try {
       // Make a file of 11MB to upload in parts, whose min required size is 
5MB.
       createDummyFile(fileToCopy, 11 * 1024 * 1024);
-      System.out.println("fileToCopy.length:" + fileToCopy.length());
       _s3PinotFS.setMultiPartUploadConfigs(1, 5 * 1024 * 1024);
       try {
         _s3PinotFS.copyFromLocalFile(fileToCopy, 
URI.create(String.format(FILE_FORMAT, SCHEME, BUCKET, fileName)));
diff --git 
a/pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java
 
b/pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java
index 7ebb10a331..edd1755608 100644
--- 
a/pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java
+++ 
b/pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufCodeGenMessageDecoder.java
@@ -100,7 +100,6 @@ public class ProtoBufCodeGenMessageDecoder implements 
StreamMessageDecoder<byte[
     try {
       simpleCompiler.cook(code);
     } catch (Throwable t) {
-      System.out.println("Protobuf codegen compile error: \n" + code);
       throw new RuntimeException(
           "Program cannot be compiled. This is a bug. Please file an issue.", 
t);
     }
diff --git 
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java
 
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java
index dc24badb47..81a1c4d3f8 100644
--- 
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java
+++ 
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java
@@ -285,7 +285,6 @@ public class ComplexTypeTransformerTest {
     fieldsToUnnest.add("level1");
     fieldsToUnnest.add("level1.level2.level3");
 
-    System.out.println(genericRow);
     ComplexTypeTransformer complexTypeTransformer = new 
ComplexTypeTransformer(fieldsToUnnest, ".");
     GenericRow result = complexTypeTransformer.transform(genericRow);
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to