gortiz opened a new pull request, #14185: URL: https://github.com/apache/pinot/pull/14185
This PR declares Java annotation processors as recommended since Maven 3.5 (see https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#annotationProcessorPaths). This change is pretty simple, we just need to declare the dependencies in a specific section in the plugin config. Although the older way to use this annotation processors in Maven still works, Maven shows a warning when that mode is used. ## Context Java annotation processors are a way to generate code at compile time in Java. This can be used by tools like Google Auto project (https://github.com/google/auto/tree/main) or Immutables. In Pinot we use Google AutoServices to generate Java Service Provider Interfaces (see https://www.baeldung.com/java-spi). For example this is used on IndexType. We have other open PRs at this time that use annotation processors to generate Calcite Rule config (see https://github.com/apache/pinot/pull/13943). Originally these annotation processors were just drop into the compilation classpath, but in the latest years the javac has a explicit way to define these processors. Since version 3.5, Maven supports this new javac argument, but in order to use it the dependencies must be declared explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
