xiangfu0 commented on code in PR #13956:
URL: https://github.com/apache/pinot/pull/13956#discussion_r1792178371
##########
pinot-connectors/pinot-spark-2-connector/pom.xml:
##########
@@ -35,6 +35,45 @@
</properties>
<profiles>
+ <profile>
+ <id>build-shaded-jar</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>com</pattern>
+ <shadedPattern>${shadeBase}.com</shadedPattern>
+ <includes>
+ <include>com.google.protobuf.**</include>
+ <include>com.google.common.**</include>
+ </includes>
+ </relocation>
+ </relocations>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>pinot-fastdev</id>
Review Comment:
I actually feel we can skip spark connectors modules for fastdev, since the
usage of them usually requires the shaded jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
