ankitsultana commented on code in PR #14192:
URL: https://github.com/apache/pinot/pull/14192#discussion_r1793953475


##########
pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/plan/LeafTimeSeriesPlanNode.java:
##########
@@ -72,7 +71,9 @@ public String getKlass() {
 
   @Override
   public String getExplainName() {
-    return EXPLAIN_NAME;

Review Comment:
   Yeah I think we should wait for the multistage-engine integration before 
explain plan support, so we have a cohesive way to compute them. The new 
explain mode is quite cool and we should support similar semantics for the 
time-series engine too. I'll be raising a proposal this month.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to