dinoocch commented on code in PR #14214:
URL: https://github.com/apache/pinot/pull/14214#discussion_r1797525051
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -124,34 +124,27 @@ public IdealState commit(HelixManager helixManager,
String resourceName,
Entry first = queue._pending.poll();
processed.add(first);
String mergedResourceName = first._resourceName;
Review Comment:
Not quite --
```java
private Queue getQueue(String resourceName) {
return _queues[(resourceName.hashCode() & Integer.MAX_VALUE) %
_queues.length];
}
```
So just it's a bit likely the queue only has 1 resource but not necessarily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
