ege-st commented on code in PR #14197:
URL: https://github.com/apache/pinot/pull/14197#discussion_r1802034731
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotClusterConfigs.java:
##########
@@ -168,4 +170,74 @@ public SuccessResponse deleteClusterConfig(
throw new ControllerApplicationException(LOGGER, errStr,
Response.Status.INTERNAL_SERVER_ERROR, e);
}
}
+
+ @GET
+ @Path("/cluster/groovy/analyzer/static/default")
+ @Authorize(targetType = TargetType.CLUSTER, action =
Actions.Cluster.GET_GROOVY_SECURITY_CONFIG)
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "Get the default configuration for Groovy Static
analysis",
+ notes = "Get the default configuration for Groovy static analysis")
+ @ApiResponses(value = {
+ @ApiResponse(code = 200, message = "Success"),
+ @ApiResponse(code = 500, message = "Internal server error")
+ })
+ public GroovyStaticAnalyzerConfig getDefaultGroovyStaticAnalysisConfig() {
+ return GroovyStaticAnalyzerConfig.createDefault();
Review Comment:
Starting here:
https://github.com/apache/pinot/pull/14197/files#diff-106af3bbf7f8d5f13d3ccb902ed2cfc28edb30931dfeb0ac8d64a7a64c373cfeR97
Assuming backwards compatible means that it won't break exist (safe)
scripts, then testing so far looks good, but I'm working with Minesh to see
what functions current customers are running in Groovy scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
