Jackie-Jiang commented on code in PR #14235:
URL: https://github.com/apache/pinot/pull/14235#discussion_r1802466898
##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##########
@@ -170,8 +173,15 @@ public static List<Configuration>
applyDynamicEnvConfig(List<Configuration> conf
Map<String, String> environmentVariables) {
return configurations.stream().peek(configuration -> {
for (String dynamicEnvConfigVarName :
configuration.getStringArray(ENV_DYNAMIC_CONFIG_KEY)) {
- configuration.setProperty(dynamicEnvConfigVarName,
-
environmentVariables.get(configuration.getString(dynamicEnvConfigVarName)));
+ //if the environment variable doesn't exist or the property is already
checked do not add the property
Review Comment:
Seems we are not checking whether the property already exists. Is this
expected? If so, let's modify the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
