tibrewalpratik17 opened a new pull request, #14293:
URL: https://github.com/apache/pinot/pull/14293
label:
`bugfix`
At present, while using DELETE API `"/segments/{tableName}/choose"` we
always end up deleting consuming segments. This is because of using common
segments selection logic across GET and DELETE APIs.
The root cause is the following line in the selection logic.
https://github.com/apache/pinot/blob/f251f00182a75dd79f2a7388546e92fb2a1658e6/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java#L951-L954
For consuming segment, we don't have startTime and endTime in ZK populated.
For fixing, we have introduced a variable `excludeConsuming` in the selection
logic to still use the same method for GET and DELETE APIs. For DELETE, we mark
excludeConsuming as true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
