bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1821927612
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java:
##########
@@ -42,36 +51,43 @@ public Object dateTimeConvert(String timeValueStr, String
inputFormatStr, String
_inputFormatSpec = new DateTimeFormatSpec(inputFormatStr);
_outputFormatSpec = new DateTimeFormatSpec(outputFormatStr);
_granularitySpec = new DateTimeGranularitySpec(outputGranularityStr);
+ _dateTime = new MutableDateTime(0L, DateTimeZone.UTC);
+ _buffer = new StringBuilder();
Review Comment:
Added in latest commit.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java:
##########
@@ -42,14 +46,26 @@ public abstract class BaseDateTimeTransformer<I, O>
implements DataTransformer<I
private final DateTimeFormatter _outputDateTimeFormatter;
private final DateTimeGranularitySpec _outputGranularity;
private final long _outputGranularityMillis;
- private final SDFDateTimeTruncate _dateTimeTruncate;
+ private final SDFDateTimeTruncate _sdfDateTimeTruncate;
+ private final MillisDateTimeTruncate _millisDateTimeTruncate;
+ private final Chronology _bucketingChronology;
+ private final MutableDateTime _dateTime;
+ private final StringBuilder _printBuffer;
private interface SDFDateTimeTruncate {
- String truncate(DateTime dateTime);
+ String truncate(MutableDateTime dateTime);
}
- public BaseDateTimeTransformer(@Nonnull DateTimeFormatSpec inputFormat,
@Nonnull DateTimeFormatSpec outputFormat,
- @Nonnull DateTimeGranularitySpec outputGranularity) {
+ private interface MillisDateTimeTruncate {
+ long truncate(MutableDateTime dateTime);
+ }
+
+ public BaseDateTimeTransformer(
+ @Nonnull DateTimeFormatSpec inputFormat,
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
