yashmayya commented on PR #14289: URL: https://github.com/apache/pinot/pull/14289#issuecomment-2449019989
> In Calcite, FLOAT is a synonym for DOUBLE (see [here](https://calcite.apache.org/docs/reference.html)), and we'll need to map FLOAT in pinot to REAL Ah yeah, I did do this for `FLOAT_ARRAY`, but missed adding it for `FLOAT`. > Suggest adding a test to verify all supported types I've added test cases for all supported types (from [here](https://github.com/apache/pinot/blob/7879e07b172d7cabe48da496c748273b1a690446/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java#L101-L109)) to `QueryCompilationTest` which will verify that the Calcite type inference is valid and that the query compiles. There's already existing tests for the transform function itself so I don't think we need to validate that separately for the multi-stage engine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
