yashmayya opened a new pull request, #14387:
URL: https://github.com/apache/pinot/pull/14387

   - Redo of https://github.com/apache/pinot/pull/13645. Similar to 
https://github.com/apache/pinot/pull/14275, this patch also adds a new 
configuration (defaulting to `false`) to allow enabling TLS between brokers and 
servers for the multi-stage engine separately from the single-stage engine.
   - This patch also wires up the dispatch client used by the query dispatcher 
in the broker to send query plans to workers / servers correctly.
   - The query server uses the existing `pinot.server.tls...` configurations 
and the query dispatcher uses the existing `pinot.broker.tls` configurations.
   - A small integration test has also been added to verify that things work 
fine with TLS enabled for the multi-stage engine. If the configuration is 
removed from the broker and only added to the server, the test fails with the 
same error due to which the original PR was reverted (see 
https://github.com/apache/pinot/pull/14259) - 
   ```
   Caught exception executing request 2087751584000000000: SELECT COUNT(*) FROM 
(SELECT AirlineID FROM mytable WHERE ArrDelay >= 0 LIMIT 1000000), Error 
dispatching query: 2087751584000000000 to server: localhost@{64489,64490}
   
org.apache.pinot.query.service.dispatch.QueryDispatcher.execute(QueryDispatcher.java:268)
   
org.apache.pinot.query.service.dispatch.QueryDispatcher.submit(QueryDispatcher.java:213)
   
org.apache.pinot.query.service.dispatch.QueryDispatcher.submitAndReduce(QueryDispatcher.java:125)
   
org.apache.pinot.broker.requesthandler.MultiStageBrokerRequestHandler.handleRequest(MultiStageBrokerRequestHandler.java:231)
   UNAVAILABLE: Network closed for unknown reason
   io.grpc.Status.asRuntimeException(Status.java:532)
   
io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:481)
   
io.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:489)
   
io.grpc.internal.DelayedClientCall$DelayedListener.delayOrExecute(DelayedClientCall.java:453)
   ```
   - In a future patch, we can also add TLS support to the gRPC mailbox server 
and the gRPC sending mailbox that are used for data shuffle in the multi-stage 
engine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to