bziobrowski commented on code in PR #14388:
URL: https://github.com/apache/pinot/pull/14388#discussion_r1829272975
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/ProjectionBlockValSet.java:
##########
@@ -135,6 +139,9 @@ public double[] getDoubleValuesSV() {
try (InvocationScope scope =
Tracing.getTracer().createScope(ProjectionBlockValSet.class)) {
recordReadValues(scope, DataType.DOUBLE, true);
return _dataBlockCache.getDoubleValuesForSVColumn(_column);
+ } catch (RuntimeException re) {
Review Comment:
Probably because it's really hard to trigger those conversions in both
engines :)
You're right, I'll add them and try to test with stub aggregate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
