ilamhs opened a new pull request, #14414:
URL: https://github.com/apache/pinot/pull/14414

   ### Labels:
   * `feature`
   * `release-notes` (backward compatible, note the deprecation, later on major 
semver remove the deprecation)
   
   ### Context
   * https://github.com/apache/pinot/issues/13556
   * Supersedes this draft solution at 
https://github.com/apache/pinot/pull/13637
   
   This allows for using properties of the `Request` object in the 
`AccessControl` to achieve things like using the peer TLS certificates to 
assign roles ( tested and running in Production with this PR on our cluster 
using `Request`)
   
   ### Notes
   * Backward compatible - Existing users of `AccessControl` interface who only 
define the deprecated methods have the exact same behavior as well (ignoring 
the `Request` essentially)
   * Updated the usage of `AccessControl` across Pinot source with the new 
methods only ( the deprecated methods are not used in the Pinot source anymore 
- comes in very handy at dropping the deprecation)
   * Not quite sure on how to sequence dropping the deprecation in a next major 
version release, would a Github issue or a release tracker note be the right 
way? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to