praveenc7 commented on PR #14383: URL: https://github.com/apache/pinot/pull/14383#issuecomment-2483914800
> > > > Modify Parser to strip matrix parameter when checking for basePath > > > > > > > > > @praveenc7 ,Pinot does not support MatrixParam. Can you elaborate on the context of handling MatrixParam for top-level resources only? > > > > > > @soumitra-st I don't quite understand, we are striping the matixParamter during urlCheck and not handling for any specific case. Can you provide more details or example on what you mean? > > You are stripping the matrixparams from the URL before, `https://pinot.example.com/file.txt;param1=value1` will behave as `https://pinot.example.com/file.txt` . My questions is, why have `https://pinot.example.com/file.txt;param1=value1` URL? IMO, Pinot does not support MatrixParam, it supports QueryParam . Thanks for the question. You’re right that Pinot doesn’t support MatrixParam but instead relies on QueryParam. However, users may unintentionally or maliciously include special characters after matrix-style parameters (;) in URLs, which could pose security risks if not handled properly. cc : @siddharthteotia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
