Jackie-Jiang commented on code in PR #14385:
URL: https://github.com/apache/pinot/pull/14385#discussion_r1847473141
##########
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/TimePredicateFilterOptimizer.java:
##########
@@ -411,6 +428,80 @@ && isStringLiteral(dateTimeConvertOperands.get(3)),
}
}
+ private void optimizeDateTrunc(Function filterFunction, FilterKind
filterKind) {
+ List<Expression> filterOperands = filterFunction.getOperands();
+ List<Expression> dateTruncOperands =
filterOperands.get(0).getFunctionCall().getOperands();
+
+ // Check if date trunc function is being applied on a literal value
+ if (dateTruncOperands.get(1).isSetLiteral()) {
+ return;
+ }
+
+ Long lowerMillis = null;
+ Long upperMillis = null;
+ DateTimeFormatSpec inputFormat = new DateTimeFormatSpec("TIMESTAMP");
+ String inputTimeUnit = (dateTruncOperands.size() >= 3) ?
dateTruncOperands.get(2).getLiteral().getStringValue()
+ : TimeUnit.MILLISECONDS.name();
+ String outputTimeUnit = (dateTruncOperands.size() == 5) ?
dateTruncOperands.get(4).getLiteral().getStringValue()
+ : TimeUnit.MILLISECONDS.name();
+ boolean lowerInclusive = true;
+ boolean upperInclusive = true;
+ List<Expression> operands = new ArrayList<>(dateTruncOperands);
+ switch (filterKind) {
+ case EQUALS:
+ operands.set(1, getExpression(filterOperands.get(1), inputFormat,
inputTimeUnit, outputTimeUnit));
+ lowerMillis = dateTruncFloor(operands);
+ upperMillis = dateTruncCeil(operands);
+ // Check if it is impossible to obtain literal equality
+ if (lowerMillis !=
TimeUnit.valueOf(inputTimeUnit).convert(getLongValue(filterOperands.get(1)),
+ TimeUnit.valueOf(outputTimeUnit))) {
+ lowerMillis = Long.MAX_VALUE;
+ upperMillis = Long.MIN_VALUE;
+ }
+ break;
+ case GREATER_THAN:
+ lowerInclusive = false;
+ operands.set(1, getExpression(filterOperands.get(1), inputFormat,
inputTimeUnit, outputTimeUnit));
+ lowerMillis = dateTruncCeil(operands);
+ break;
+ case GREATER_THAN_OR_EQUAL:
+ operands.set(1, getExpression(filterOperands.get(1), inputFormat,
inputTimeUnit, outputTimeUnit));
+ lowerInclusive = false;
+ lowerMillis = dateTruncCeil(operands);
+ if (dateTruncFloor(operands)
+ ==
inputFormat.fromFormatToMillis(getLongValue(filterOperands.get(1)))) {
+ lowerInclusive = true;
+ lowerMillis = dateTruncFloor(operands);
+ }
+ break;
+ case LESS_THAN:
+ upperInclusive = false;
+ operands.set(1, getExpression(filterOperands.get(1), inputFormat,
inputTimeUnit, outputTimeUnit));
+ upperMillis = dateTruncFloor(operands);
+ if (upperMillis !=
inputFormat.fromFormatToMillis(getLongValue(filterOperands.get(1)))) {
+ upperInclusive = true;
+ upperMillis = dateTruncCeil(operands);
+ }
+ break;
+ case LESS_THAN_OR_EQUAL:
+ operands.set(1, filterOperands.get(1));
+ upperMillis = dateTruncCeil(operands);
+ break;
+ case BETWEEN:
+ operands.set(1, getExpression(filterOperands.get(1), inputFormat,
inputTimeUnit, outputTimeUnit));
+ operands.set(1, getExpression(filterOperands.get(2), inputFormat,
inputTimeUnit, outputTimeUnit));
+ upperMillis = dateTruncCeil(operands);
+ break;
+ default:
+ throw new IllegalStateException();
Review Comment:
It should be fine because this method is under the branch of `if
(filterKind.isRange() || filterKind == FilterKind.EQUALS)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
