yashmayya commented on code in PR #14476:
URL: https://github.com/apache/pinot/pull/14476#discussion_r1848060900
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/grpc/GrpcQueryClient.java:
##########
@@ -62,13 +62,15 @@ public GrpcQueryClient(String host, int port) {
public GrpcQueryClient(String host, int port, GrpcConfig config) {
ManagedChannelBuilder<?> channelBuilder;
if (config.isUsePlainText()) {
- channelBuilder =
- ManagedChannelBuilder.forAddress(host,
port).maxInboundMessageSize(config.getMaxInboundMessageSizeBytes())
- .usePlaintext();
+ channelBuilder = ManagedChannelBuilder
Review Comment:
Only refactors in this file.
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/grpc/GrpcQueryServer.java:
##########
@@ -105,7 +105,7 @@ public GrpcQueryServer(int port, GrpcConfig config,
TlsConfig tlsConfig, QueryEx
_serverMetrics = serverMetrics;
if (tlsConfig != null) {
try {
- _server =
NettyServerBuilder.forPort(port).sslContext(buildGRpcSslContext(tlsConfig))
+ _server =
NettyServerBuilder.forPort(port).sslContext(buildGrpcSslContext(tlsConfig))
Review Comment:
Only refactors in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
