gortiz commented on code in PR #14489:
URL: https://github.com/apache/pinot/pull/14489#discussion_r1851768550
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RegexpExtractTransformFunction.java:
##########
@@ -81,10 +81,10 @@ public void init(List<TransformFunction> arguments,
Map<String, ColumnContext> c
}
if (arguments.size() == 4) {
- TransformFunction positionFunction = arguments.get(3);
- Preconditions.checkState(positionFunction instanceof
LiteralTransformFunction,
+ TransformFunction defaultValueTransformFunction = arguments.get(3);
+ Preconditions.checkState(defaultValueTransformFunction instanceof
LiteralTransformFunction,
"`default_value` must be a literal expression.");
- _defaultValue = ((LiteralTransformFunction)
regexpFunction).getStringLiteral();
+ _defaultValue = ((LiteralTransformFunction)
defaultValueTransformFunction).getStringLiteral();
} else {
Review Comment:
Oh! Forget what I said, I didn't see we are using a different variable in
line 87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
