swaminathanmanish commented on code in PR #14355: URL: https://github.com/apache/pinot/pull/14355#discussion_r1852548401
########## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/DimensionValueTransformer.java: ########## @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.minion.tasks.mergerollup; + +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import org.apache.pinot.segment.local.recordtransformer.RecordTransformer; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * The {@code DimensionValueTransformer} class will transform certain dimension values by substituting the + * existing value for that dimension with the 'defaultNullValue' from its 'fieldSpec'. + */ +public class DimensionValueTransformer implements RecordTransformer { Review Comment: @davecromberge - This transformer looks good but just curious if we explored whether ExpressionTransformer which is used in SegmentProcessorFramework itself be used to do this transformation, instead of a new transformer? Transform col value to null and there's a NullValueTransformer as well to replace null with a specified default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
