xiangfu0 commented on code in PR #14537:
URL: https://github.com/apache/pinot/pull/14537#discussion_r1857491186
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java:
##########
@@ -347,4 +347,9 @@ public static double[] generateDoubleArray(double start,
double end, double inc)
}
return arr;
}
+
+ @ScalarFunction
+ public static String arrayJoinString(String[] values, String delimiter) {
Review Comment:
Yeah, let's call it `arrayToString`. Pinot internally handles naming
transfer for `array_to_string` to `arrayToString`.
You could also verify this in the test as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
