raghavyadav01 commented on code in PR #14582:
URL: https://github.com/apache/pinot/pull/14582#discussion_r1868670365
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -135,17 +133,7 @@ private MailboxContent toMailboxContent(TransferableBlock
block)
long start = System.currentTimeMillis();
try {
DataBlock dataBlock = block.getDataBlock();
- List<ByteBuffer> bytes = dataBlock.serialize();
Review Comment:
Tagging @Jackie-Jiang to take a look as @gortiz is on leave.
##########
pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/plan/TransformNullPlanNode.java:
##########
@@ -34,15 +34,20 @@ public class TransformNullPlanNode extends
BaseTimeSeriesPlanNode {
@JsonCreator
public TransformNullPlanNode(@JsonProperty("id") String id,
@JsonProperty("defaultValue") Double defaultValue,
- @JsonProperty("children") List<BaseTimeSeriesPlanNode> children) {
- super(id, children);
+ @JsonProperty("inputs") List<BaseTimeSeriesPlanNode> inputs) {
Review Comment:
Why are we changing children to inputs? Curious, does it have any
significance ?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/TimeSeriesPhysicalTableScan.java:
##########
@@ -54,6 +55,11 @@ public ExecutorService getExecutorService() {
return _executorService;
}
+ @Override
+ public BaseTimeSeriesPlanNode withInputs(List<BaseTimeSeriesPlanNode>
newInputs) {
Review Comment:
What is the idea behind withInputs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
