swaminathanmanish commented on PR #13948:
URL: https://github.com/apache/pinot/pull/13948#issuecomment-2523157822

   @chenboat , @itschrispeck - We ran into an NPE with this change.  When we 
don't have all fields populated in the TextIndexConfig, we will run into NPE, 
via code path that calls.  The call path is from newly added code 
**getUpdatedConfigFromPropertiesFile** . 
   (cc @shounakmk219) 
   
   public AbstractBuilder(TextIndexConfig other) {
         _fstType = other._fstType;
         _enableQueryCache = other._enableQueryCache;
         _useANDForMultiTermQueries = other._useANDForMultiTermQueries;
         **_stopWordsInclude = new ArrayList<>(other._stopWordsInclude);**
         **_stopWordsExclude = new ArrayList<>(other._stopWordsExclude);**
         _luceneUseCompoundFile = other._luceneUseCompoundFile;
         _luceneMaxBufferSizeMB = other._luceneMaxBufferSizeMB;
         _luceneAnalyzerClass = other._luceneAnalyzerClass;
         _enablePrefixSuffixMatchingInPhraseQueries = 
other._enablePrefixSuffixMatchingInPhraseQueries;
         _reuseMutableIndex = other._reuseMutableIndex;
         _luceneNRTCachingDirectoryMaxBufferSizeMB = 
other._luceneNRTCachingDirectoryMaxBufferSizeMB;
       }
   
   
   java.lang.RuntimeException: java.lang.NullPointerException: Cannot invoke 
"java.util.Collection.toArray()" because "c" is null
           at 
org.apache.pinot.segment.local.segment.index.readers.text.LuceneTextIndexReader.<init>(LuceneTextIndexReader.java:109)
 
~[startree-pinot-all-1.3.0-ST.33.2-jar-with-dependencies.jar:1.3.0-ST.33.2-2c89967358e92fa326338467332730af48c1d353]
           at 
org.apache.pinot.segment.local.segment.index.text.TextIndexType$ReaderFactory.createIndexReader(TextIndexType.java:184)
 
~[startree-pinot-all-1.3.0-ST.33.2-jar-with-dependencies.jar:1.3.0-ST.33.2-2c89967358e92fa326338467332730af48c1d353]
         


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to