Jackie-Jiang opened a new pull request, #14618: URL: https://github.com/apache/pinot/pull/14618
#14158 introduced the query option validation, but some of the validations are too strict and some are too loose. This PR changes the validations of the following query options: - NUM_REPLICA_GROUPS_TO_QUERY/MAX_EXECUTION_THREADS/NUM_GROUPS_LIMIT/MAX_INITIAL_RESULT_HOLDER_CAPACITY/MAX_STREAMING_PENDING_BLOCKS/MAX_ROWS_IN_JOIN/MAX_ROWS_IN_WINDOW: Must be positive - MIN_SEGMENT_GROUP_TRIM_SIZE/MIN_SERVER_GROUP_TRIM_SIZE/MIN_BROKER_GROUP_TRIM_SIZE/GROUP_TRIM_THRESHOLD: Can be negative (turn off trim) This PR also fixes the inconsistent behavior across server and broker, and allow disabling trimming with non-positive value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
