suvodeep-pyne commented on code in PR #14654:
URL: https://github.com/apache/pinot/pull/14654#discussion_r1883020639
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMetadataProvider.java:
##########
@@ -106,6 +107,33 @@ default Map<String, PartitionLagState>
getCurrentPartitionLagState(
return result;
}
+ /**
+ * Fetches the list of available topics/streams
+ *
+ * @param timeout Timeout for fetching the list of topics. If this is null,
the implementation should use a default
+ * timeout.
+ * @return List of topics
+ */
+ default List<TopicMetadata> listTopics(Duration timeout) {
Review Comment:
yes. Other APIs don't support it. However, I think starting with this API
might be helpful because, I have seen large timeouts in these API calls which
results in a bad UX downstream.
Do you recommend having a simple `listTopics()` API. I can update to that
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
