itschrispeck commented on code in PR #14688:
URL: https://github.com/apache/pinot/pull/14688#discussion_r1893304538
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamDataDecoderImpl.java:
##########
@@ -65,6 +66,7 @@ public StreamDataDecoderResult decode(StreamMessage message) {
if (metadata.getRecordMetadata() != null) {
metadata.getRecordMetadata().forEach((key, value) ->
row.putValue(METADATA_KEY_PREFIX + key, value));
}
+ row.putValue(METADATA_KEY_PREFIX + RECORD_SERIALIZED_VALUE_SIZE_KEY,
message.getLength());
Review Comment:
Consider `.getBytes()` which I think would be more accurate as the size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
