gortiz commented on code in PR #14507:
URL: https://github.com/apache/pinot/pull/14507#discussion_r1895385593
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/serde/PlanNodeDeserializer.java:
##########
@@ -117,8 +117,18 @@ private static MailboxReceiveNode
deserializeMailboxReceiveNode(Plan.PlanNode pr
private static MailboxSendNode deserializeMailboxSendNode(Plan.PlanNode
protoNode) {
Plan.MailboxSendNode protoMailboxSendNode = protoNode.getMailboxSendNode();
+
+ List<Integer> receiverIds;
+ List<Integer> protoReceiverIds =
protoMailboxSendNode.getReceiverStageIdsList();
+ if (protoReceiverIds == null || protoReceiverIds.isEmpty()) {
Review Comment:
nullability is tricky in protobuf. Depending on different configurations,
null may or may not be present. That is why I prefer to be cautious and check
for nulls just in case something change in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
