Jackie-Jiang commented on code in PR #14664:
URL: https://github.com/apache/pinot/pull/14664#discussion_r1899321259
##########
pinot-query-planner/src/test/resources/queries/GroupByPlans.json:
##########
@@ -249,6 +249,39 @@
"\n LogicalTableScan(table=[[default, a]])",
"\n"
]
+ },
Review Comment:
Leaf stage has both segment trim and server trim. Will add some javadoc
about the behavior, and we should consider adding them also as v2 hint. Right
now the behavior relies on the v1 query options.
Agree on automating it when the result is guaranteed to be accurate. This
will also require some v1 engine change, so will do it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
