Jackie-Jiang opened a new pull request, #14732: URL: https://github.com/apache/pinot/pull/14732
Calculating hash code of thrift `Expression` is super expensive, so we should reduce the hash computation as much as possible. This PR changes the `Set<Expression>` to `Map<String, Expression>` to perform the deduplication of IN predicate values. The key is the string representation of the value, which is consistent of how predicates are handle on the server side (see `RequestContextUtils.getFilter()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
