tibrewalpratik17 commented on code in PR #14721:
URL: https://github.com/apache/pinot/pull/14721#discussion_r1900468758
##########
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/ValidDocIdsMetadataInfo.java:
##########
@@ -30,17 +30,20 @@ public class ValidDocIdsMetadataInfo {
private final long _totalDocs;
private final String _segmentCrc;
private final ValidDocIdsType _validDocIdsType;
+ private final long _segmentSizeInBytes;
public ValidDocIdsMetadataInfo(@JsonProperty("segmentName") String
segmentName,
@JsonProperty("totalValidDocs") long totalValidDocs,
@JsonProperty("totalInvalidDocs") long totalInvalidDocs,
@JsonProperty("totalDocs") long totalDocs, @JsonProperty("segmentCrc")
String segmentCrc,
- @JsonProperty("validDocIdsType") ValidDocIdsType validDocIdsType) {
+ @JsonProperty("validDocIdsType") ValidDocIdsType validDocIdsType,
+ @JsonProperty("segmentSizeInBytes") long segmentSizeInBytes) {
Review Comment:
It will be null. Though we will have it for immutableSegments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
