This is an automated email from the ASF dual-hosted git repository.
pratik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7416576d55 Add segment size info to validDocIdsMetadata API call
(#14721)
7416576d55 is described below
commit 7416576d55201032a72a63012a4dc2ac4ca7818a
Author: Pratik Tibrewal <[email protected]>
AuthorDate: Thu Jan 2 03:49:57 2025 +0530
Add segment size info to validDocIdsMetadata API call (#14721)
---
.../pinot/common/restlet/resources/ValidDocIdsMetadataInfo.java | 9 ++++++++-
.../org/apache/pinot/server/api/resources/TablesResource.java | 4 ++++
.../java/org/apache/pinot/server/api/TablesResourceTest.java | 1 +
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git
a/pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/ValidDocIdsMetadataInfo.java
b/pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/ValidDocIdsMetadataInfo.java
index ce54424d16..500cfff946 100644
---
a/pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/ValidDocIdsMetadataInfo.java
+++
b/pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/ValidDocIdsMetadataInfo.java
@@ -30,17 +30,20 @@ public class ValidDocIdsMetadataInfo {
private final long _totalDocs;
private final String _segmentCrc;
private final ValidDocIdsType _validDocIdsType;
+ private final long _segmentSizeInBytes;
public ValidDocIdsMetadataInfo(@JsonProperty("segmentName") String
segmentName,
@JsonProperty("totalValidDocs") long totalValidDocs,
@JsonProperty("totalInvalidDocs") long totalInvalidDocs,
@JsonProperty("totalDocs") long totalDocs, @JsonProperty("segmentCrc")
String segmentCrc,
- @JsonProperty("validDocIdsType") ValidDocIdsType validDocIdsType) {
+ @JsonProperty("validDocIdsType") ValidDocIdsType validDocIdsType,
+ @JsonProperty("segmentSizeInBytes") long segmentSizeInBytes) {
_segmentName = segmentName;
_totalValidDocs = totalValidDocs;
_totalInvalidDocs = totalInvalidDocs;
_totalDocs = totalDocs;
_segmentCrc = segmentCrc;
_validDocIdsType = validDocIdsType;
+ _segmentSizeInBytes = segmentSizeInBytes;
}
public String getSegmentName() {
@@ -66,4 +69,8 @@ public class ValidDocIdsMetadataInfo {
public ValidDocIdsType getValidDocIdsType() {
return _validDocIdsType;
}
+
+ public long getSegmentSizeInBytes() {
+ return _segmentSizeInBytes;
+ }
}
diff --git
a/pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
b/pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
index c7da1a9b29..8568a5178c 100644
---
a/pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
+++
b/pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
@@ -714,6 +714,10 @@ public class TablesResource {
validDocIdsMetadata.put("totalInvalidDocs", totalInvalidDocs);
validDocIdsMetadata.put("segmentCrc",
indexSegment.getSegmentMetadata().getCrc());
validDocIdsMetadata.put("validDocIdsType", finalValidDocIdsType);
+ if (segmentDataManager instanceof ImmutableSegmentDataManager) {
+ validDocIdsMetadata.put("segmentSizeInBytes",
+ ((ImmutableSegment)
segmentDataManager.getSegment()).getSegmentSizeBytes());
+ }
allValidDocIdsMetadata.add(validDocIdsMetadata);
}
if (nonImmutableSegmentCount > 0) {
diff --git
a/pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java
b/pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java
index fe717fab2e..42699a78c0 100644
---
a/pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java
+++
b/pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java
@@ -347,6 +347,7 @@ public class TablesResourceTest extends BaseResourceTest {
Assert.assertEquals(validDocIdsMetadata.get("totalInvalidDocs").asInt(),
99992);
Assert.assertEquals(validDocIdsMetadata.get("segmentCrc").asText(),
"1894900283");
Assert.assertEquals(validDocIdsMetadata.get("validDocIdsType").asText(),
"SNAPSHOT");
+
Assert.assertEquals(validDocIdsMetadata.get("segmentSizeInBytes").asLong(),
1877636);
}
// Verify metadata file from segments.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
