9aman commented on code in PR #14741:
URL: https://github.com/apache/pinot/pull/14741#discussion_r1905052123
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -845,6 +846,23 @@ public void run() {
// CONSUMING -> ONLINE state transition.
segmentLock.lockInterruptibly();
try {
+ // For tables with pauseless consumption enabled we want to
start the commit protocol that
+ // 1. Updates the endOffset in the ZK metadata for the
committing segment
+ // 2. Creates ZK metadata for the new consuming segment
+ // 3. Updates the IdealState for committing and new consuming
segment to ONLINE and CONSUMING
+ // respectively.
+ // See design doc for the new commit protocol:
+ //
https://docs.google.com/document/d/1d-xttk7sXFIOqfyZvYw5W_KeGS6Ztmi8eYevBcCrT_c
Review Comment:
Have linked the PR and updated the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
