ankitsultana opened a new issue, #14781: URL: https://github.com/apache/pinot/issues/14781
Currently, the `PinotJoinToDynamicBroadcastRule` is applied even if there's no explicit hint provided. While it's great to have this optimization, it shouldn't be ON by default (at least for Uber.. some other companies may prefer it). Hence it would be great if we can make it so that this rule doesn't get auto applied for every query. We can't change the default behavior now I guess since it would be backwards incompatible, so the most natural solution to me is to make it configurable. QueryEnvironment could pass in the broker config to PinotQueryRuleSets, which can pass the config to the eligible rules. Forward looking guideline: I think we should only use configurations for rules in exceptional scenarios like this one, since adding complexity to the rule set would make testing harder. cc: @shauryachats -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
