Jackie-Jiang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1908313579
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
throws Exception {
FileUtils.deleteQuietly(new File(TEMP_SERVER_DIR));
for (int i = 0; i < numServers; i++) {
- _serverStarters.add(startOneServer(i));
+ BaseServerStarter serverStarter = startOneServer(i);
+ _serverStarters.add(serverStarter);
+ _helixAdmin.enableInstance(getHelixClusterName(),
serverStarter.getInstanceId(), true);
Review Comment:
What has been changed that causes this test to fail without adding this
line? Are we explicitly checking for `HELIX_ENABLED` set to true?
What concerns me is that we shouldn't need to explicitly enable an instance,
and we are not doing so when adding a new instance to the cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
