bziobrowski opened a new pull request, #14783:
URL: https://github.com/apache/pinot/pull/14783
PR changes IJ formatter to align multiline method declaration parameters.
Current settings make multi-param declarations hard to read because
everything is crammed into as few lines as possible.
With alignment enabled, declaration such as :
```java
public MultistageGroupByExecutor(int[] groupKeyIds, AggregationFunction[]
aggFunctions, int[] filterArgIds,
int maxFilterArgId, AggType aggType, boolean leafReturnFinalResult,
DataSchema resultSchema,
Map<String, String> opChainMetadata, @Nullable PlanNode.NodeHint
nodeHint) {
```
can be reformatted as
```java
public MultistageGroupByExecutor(int[] groupKeyIds,
AggregationFunction[] aggFunctions,
int[] filterArgIds,
int maxFilterArgId, AggType aggType,
boolean leafReturnFinalResult,
DataSchema resultSchema,
Map<String, String> opChainMetadata,
@Nullable PlanNode.NodeHint nodeHint) {
```
or
```java
public MultistageGroupByExecutor(
int[] groupKeyIds,
AggregationFunction[] aggFunctions,
int[] filterArgIds,
int maxFilterArgId, AggType aggType,
boolean leafReturnFinalResult,
DataSchema resultSchema,
Map<String, String> opChainMetadata,
@Nullable PlanNode.NodeHint nodeHint) {
```
or differently - with multiple parameters per line - but with first
parameter aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
