siddharthteotia commented on code in PR #14823:
URL: https://github.com/apache/pinot/pull/14823#discussion_r1917835462
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -865,6 +896,48 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
+ private String maybeSaveClientQueryId(long requestId, SqlNodeAndOptions
sqlNodeAndOptions) {
+ if (!isQueryCancellationEnabled()) {
+ return null;
+ }
+ String clientQueryId = extractClientQueryId(sqlNodeAndOptions);
+ if (StringUtils.isBlank(clientQueryId)) {
+ return null;
Review Comment:
(nit) in general we don't recommend returning NULL as a coding practice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
